no-jira: Fix double close on <Popover> #185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Facing the same issue, but with Dropdown. I think it's related to reactwg/react-18#21 in React 18, since it worked fine for us in 17. The popper element isn't in the tree when the click outside handler runs, because react is now patiently waiting till the react vdom settles down to write the current DOM state. This means the click handler sees a click happening outside the dom. I think this is why that div ref is required, it's always present on the document."" CC: @ls-jf-gagnon, is it still possible to make a release of flame from this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Which problem(s) does it solve and how? What does this PR add?
How to test?
yarn devChecklist