Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove container usage #241

Merged
merged 1 commit into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions .github/actions/install/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
name: "V8 install"
description: "Install deps for the project"

inputs:
zig:
description: 'Zig version to install'
required: false
default: '0.12.1'
arch:
description: 'CPU arch used to select the v8 lib'
required: false
default: 'x86_64'
os:
description: 'OS used to select the v8 lib'
required: false
default: 'linux'
zig-v8:
description: 'zig v8 version to install'
required: false
default: 'v0.1.5'
v8:
description: 'v8 version to install'
required: false
default: '11.1.134'
cache-dir:
description: 'cache dir to use'
required: false
default: '~/.cache'

runs:
using: "composite"

steps:
- uses: mlugg/setup-zig@v1
with:
version: ${{ inputs.zig }}

- name: Cache v8
id: cache-v8
uses: actions/cache@v3
env:
cache-name: cache-v8
with:
path: ${{ inputs.cache-dir }}/v8
key: libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a

- if: ${{ steps.cache-v8.outputs.cache-hit != 'true' }}
shell: bash
run: |
mkdir -p ${{ inputs.cache-dir }}/v8

wget -O ${{ inputs.cache-dir }}/v8/libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${{ inputs.zig-v8 }}/libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a

- name: install v8
shell: bash
run: |
mkdir -p vendor/v8/${{inputs.arch}}-${{inputs.os}}/debug
ln -s ${{ inputs.cache-dir }}/v8/libc_v8.a vendor/v8/${{inputs.arch}}-${{inputs.os}}/debug/libc_v8.a

mkdir -p vendor/v8/${{inputs.arch}}-${{inputs.os}}/release
ln -s ${{ inputs.cache-dir }}/v8/libc_v8.a vendor/v8/${{inputs.arch}}-${{inputs.os}}/release/libc_v8.a
26 changes: 4 additions & 22 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: benchmark

env:
ARCH: x86_64-linux
AWS_ACCESS_KEY_ID: ${{ vars.LPD_PERF_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.LPD_PERF_AWS_SECRET_ACCESS_KEY }}
AWS_BUCKET: ${{ vars.LPD_PERF_AWS_BUCKET }}
Expand Down Expand Up @@ -35,35 +34,18 @@ jobs:
benchmark:
name: benchmark

# Don't run the CI with draft PR.
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest
container:
image: ghcr.io/lightpanda-io/zig-v8:0.12.1
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# docker blocks io_uring syscalls by default now.
# see https://github.com/tigerbeetle/tigerbeetle/pull/1995
# see https://github.com/moby/moby/pull/46762
options: "--security-opt seccomp=unconfined"
# Don't run the CI with draft PR.
if: github.event.pull_request.draft == false

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GH_CI_PAT }}
submodules: true

- name: install v8
run: |
mkdir -p vendor/v8/${{env.ARCH}}/debug
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/debug/libc_v8.a

mkdir -p vendor/v8/${{env.ARCH}}/release
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/release/libc_v8.a
- uses: ./.github/actions/install

- run: zig build -Doptimize=ReleaseSafe -Dengine=v8
- name: run benchmark
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/zig-fmt.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: zig-fmt

env:
ZIG_VERSION: 0.12.1

on:
pull_request:

Expand Down Expand Up @@ -27,16 +30,13 @@ jobs:
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest
container:
image: ghcr.io/lightpanda-io/zig:0.12.1
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
outputs:
zig_fmt_errs: ${{ steps.fmt.outputs.zig_fmt_errs }}

steps:
- uses: actions/checkout@v3
- uses: mlugg/setup-zig@v1
with:
version: ${{ env.ZIG_VERSION }}

- uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
54 changes: 5 additions & 49 deletions .github/workflows/zig-test.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
name: zig-test

env:
ARCH: x86_64-linux

on:
push:
branches:
Expand Down Expand Up @@ -39,26 +36,14 @@ jobs:
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest
container:
image: ghcr.io/lightpanda-io/zig-v8:0.12.1
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GH_CI_PAT }}
submodules: true

- name: install v8
run: |
mkdir -p vendor/v8/${{env.ARCH}}/debug
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/debug/libc_v8.a

mkdir -p vendor/v8/${{env.ARCH}}/release
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/release/libc_v8.a
- uses: ./.github/actions/install

- name: zig build debug
run: zig build -Dengine=v8
Expand All @@ -70,26 +55,14 @@ jobs:
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest
container:
image: ghcr.io/lightpanda-io/zig-v8:0.12.1
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
token: ${{ secrets.GH_CI_PAT }}
submodules: true

- name: install v8
run: |
mkdir -p vendor/v8/${{env.ARCH}}/debug
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/debug/libc_v8.a

mkdir -p vendor/v8/${{env.ARCH}}/release
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/release/libc_v8.a
- uses: ./.github/actions/install

- name: zig build release
run: zig build -Doptimize=ReleaseSafe -Dengine=v8
Expand All @@ -101,31 +74,14 @@ jobs:
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest
container:
image: ghcr.io/lightpanda-io/zig-v8:0.12.1
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# docker blocks io_uring syscalls by default now.
# see https://github.com/tigerbeetle/tigerbeetle/pull/1995
# see https://github.com/moby/moby/pull/46762
options: "--security-opt seccomp=unconfined"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GH_CI_PAT }}
submodules: true

- name: install v8
run: |
mkdir -p vendor/v8/${{env.ARCH}}/debug
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/debug/libc_v8.a

mkdir -p vendor/v8/${{env.ARCH}}/release
ln -s /usr/local/lib/libc_v8.a vendor/v8/${{env.ARCH}}/release/libc_v8.a
- uses: ./.github/actions/install

- name: zig build test
run: zig build test -Dengine=v8
Loading