Free temporary slices #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a breaking change. Before slices (strings) where kept in heap and the API functions didn't have to worry about that. Now those slices are freed after the function call, so the API functions needs to allocate (ie. copy) those slices if they want them to stay in memory. Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
force-pushed
the
free_js_slices
branch
from
a8704b4 to
8b13740
Compare
krichprollsch
approved these changes
Nov 24, 2023
francisbouvier
added a commit
that referenced
this pull request
Nov 26, 2023
Relates to #111 Fix #142 Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
added a commit
to lightpanda-io/browser
that referenced
this pull request
Nov 26, 2023
Relates to PR lightpanda-io/zig-js-runtime#111 Relates to issue lightpanda-io/zig-js-runtime#142 Signed-off-by: Francis Bouvier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a breaking change.
Before slices (strings) where kept in heap and the API functions didn't have to worry about that.
Now those slices are freed after the function call, so the API functions needs to allocate (ie. copy) those slices if they want them to stay in memory.
Closes #111