Merge pull request #244 from lightpanda-io/trycatch-env-not-started

try_catch: check if the env is started before get it
lightpanda-io · Jul 19, 2024 · ade128f · ade128f
2 parents a486251 + 31d4b8c
commit ade128f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/engines/v8/v8.zig b/src/engines/v8/v8.zig
@@ -453,6 +453,8 @@ pub const TryCatch = struct {
 
     // the caller needs to deinit the string returned
     pub fn exception(self: TryCatch, alloc: std.mem.Allocator, env: Env) anyerror!?[]const u8 {
+        if (env.js_ctx == null) return error.EnvNotStarted;
+
         if (self.inner.getException()) |msg| {
             return try valueToUtf8(alloc, msg, env.isolate, env.js_ctx.?);
         }
@@ -461,6 +463,8 @@ pub const TryCatch = struct {
 
     // the caller needs to deinit the string returned
     pub fn stack(self: TryCatch, alloc: std.mem.Allocator, env: Env) anyerror!?[]const u8 {
+        if (env.js_ctx == null) return error.EnvNotStarted;
+
         const stck = self.inner.getStackTrace(env.js_ctx.?);
         if (stck) |s| return try valueToUtf8(alloc, s, env.isolate, env.js_ctx.?);
         return null;