fix: avoid requesting validation endpoint when no permission #10085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't have access to that feature.
👷 Deploy request for peaceful-bassi-cbf284 pending review.Visit the deploys page to approve it
|
owlas
requested a deployment
to
duplicate_Fix-getting-project-validation - jaffle_db_pg_13 PR #10099
Render
Abandoned
owlas
deployed
to
duplicate_Fix-getting-project-validation - headless-browser PR #10099
Render
Active
3 tasks
joaoviana
changed the title
|
Just changed the description of the PR @anshul45, reviewing this now, and running E2E tests 👍 |
owlas
temporarily deployed
to
duplicate_Fix-getting-project-validation - lightdash PR #10099
Render
Destroyed
|
Pushed 2 changes here @anshul45
Will merge once this passes E2E tests! |
joaoviana
approved these changes
May 17, 2024
|
Thank you for contributing to Lightdash 🎉 |
|
@all-contributors add @anshul45 for code |
|
I've put up a pull request to add @anshul45! 🎉 |
lightdash-bot
pushed a commit
that referenced
this pull request
May 17, 2024
|
🎉 This PR is included in version 0.1097.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@joaoviana Thank you for taking the time to review my pull request and optimize my code! I have learned a lot from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: (#9327)
Description:
Fix the project validation details request if the user does not have permission to do so. I've figured out how it's validated on the Backend. Based on this. I've validate the user on the Frontend before making the validation request.
Reviewer actions