fix: display missing custom metrics and dimensions #10070
Conversation
owlas
requested a deployment
to
fix/missing-custom-dim-metric - jaffle_db_pg_13 PR #10070
Render
Abandoned
owlas
deployed
to
fix/missing-custom-dim-metric - headless-browser PR #10070
Render
Active
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
almeidabbm
changed the title
almeidabbm
requested review from
a team and
rephus
and removed request for
a team
| return ( | ||
| !table || | ||
| (metric.baseDimensionName && | ||
| !table.dimensions[metric.baseDimensionName]) |
There was a problem hiding this comment.
why did you change this ? I thought the problem was only on custom dimensions
There was a problem hiding this comment.
yeah, ended up noticing as well that if the base dimension for a custom metric was removed the custom metric wouldn't show as missing
Screen.Recording.2024-05-14.at.16.07.46.mov
|
|
||
| return ( | ||
| !table || | ||
| (isCustomBinDimension(customDimension) && |
There was a problem hiding this comment.
do we also need to check if isCustomSqlDimension ?
There was a problem hiding this comment.
good point, I had a look at that and customSqlDimension but since it doesn't have a base dimension and it's only sql I couldn't do it like this, probably can only do it after compiling?
There was a problem hiding this comment.
I believe I was able to do this in the latest commit:
Screen.Recording.2024-05-16.at.09.42.11.mov
owlas
temporarily deployed
to
fix/missing-custom-dim-metric - lightdash PR #10070
Render
Destroyed
owlas
temporarily deployed
to
fix/missing-custom-dim-metric - headless-browser PR #10070
Render
Destroyed
## [0.1096.3](0.1096.2...0.1096.3) (2024-05-16) ### Bug Fixes * display missing custom metrics and dimensions ([#10070](#10070)) ([e41b9a8](e41b9a8))
|
🎉 This PR is included in version 0.1096.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes: #10066
Description:
Screen.Recording.2024-05-14.at.15.17.15.mov
Reviewer actions