Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table calculation group stack #10065

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

rephus
Copy link
Collaborator

@rephus rephus commented May 14, 2024

Closes: #10051

Description:

Before:
Screenshot from 2024-05-14 10-10-42

After:

Screencast.from.14-05-24.10.15.20.webm

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@rephus rephus requested a review from magnew May 14, 2024 08:22
@owlas owlas requested a deployment to fix-table-calculation-group-type - jaffle_db_pg_13 PR #10065 May 14, 2024 08:22 — with Render Abandoned
@owlas owlas temporarily deployed to fix-table-calculation-group-type - headless-browser PR #10065 May 14, 2024 08:22 — with Render Destroyed
Copy link

netlify bot commented May 14, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 61cd5b3
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66431f30bed6f00008ea4fba

@owlas owlas temporarily deployed to fix-table-calculation-group-type - lightdash PR #10065 May 14, 2024 08:23 — with Render Destroyed
@rephus rephus requested a review from almeidabbm May 16, 2024 08:55
@rephus rephus merged commit 943438b into main May 16, 2024
50 of 54 checks passed
@rephus rephus deleted the fix-table-calculation-group-type branch May 16, 2024 11:48
lightdash-bot pushed a commit that referenced this pull request May 16, 2024
## [0.1096.4](0.1096.3...0.1096.4) (2024-05-16)

### Bug Fixes

* table calculation group stack ([#10065](#10065)) ([943438b](943438b))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1096.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacking with a non-numeric x-axis then switching to a numeric x-axis breaks my chart.
4 participants