Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --output-filename to output generated objects to #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --output-filename to output generated objects to #25

wants to merge 1 commit into from

Conversation

terraboops
Copy link

Fixes #3

  • file written to tmp location initially and moved to the final path
  • currently writing all objects to the same file, but this could be changed
    • writing different objects to different files will require passing a bunch of flags or using predefined filenames with a user defined prefix, this seems inconvenient for maintenance as well as for users

@terraboops @jeffWelling @rmkbow
Add --output-filename to output generated objects to
e139f26 
Co-authored-by: Jeff Welling <[email protected]>
Co-authored-by: Ronald Bow <[email protected]>
@terraboops
Copy link
Author

Please let me know if there's anything else I can improve or fix with this PR! Thanks @liggitt :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying a file/folder to output generated objects to
1 participant
@terraboops