Skip to content

Commit

Permalink
Update how secrets are masked.
Browse files Browse the repository at this point in the history
Due to #78 and #79 it not a good idea to override the built in ps
functions in the way that we are now. I've modified how secrets are
masked. Currently secrets will always be masked. The implementation is not
quite as safe as the previous because previoulsy psbuild was overriding
commands like write-host, write-output, etc to mask secrets. That had
issues where the prompt was getting modified. Instead of that I've updated
calls that can cause output to call Get-FilteredString instead. Including
masking any exception messages. I'm pretty confident that secrets are
still being masked correctly including in log files.
  • Loading branch information
sayedihashimi committed Apr 2, 2016
1 parent 0f01b8f commit ce2386b
Show file tree
Hide file tree
Showing 3 changed files with 185 additions and 208 deletions.
Loading

0 comments on commit ce2386b

Please sign in to comment.