profile actions bar reworked into dropdown for mobile only #14205
Conversation
awestm
force-pushed
the
profile-actions-popup
branch
2 times, most recently
from
09507c4
to
dfeedfb
Compare
awestm
force-pushed
the
profile-actions-popup
branch
from
66ef468
to
d421740
Compare
|
What the proposed change would look like (also mentioned in #13991):
|
awestm
force-pushed
the
profile-actions-popup
branch
from
d421740
to
354b0a7
Compare
awestm
force-pushed
the
profile-actions-popup
branch
from
354b0a7
to
80924eb
Compare
|
Removed list on desktop as requested. desktop-list.mp4mobile-list.mp4 |
awestm
changed the title
| trans.reportXToModerators.txt(u.username) | ||
| ) | ||
| ) | ||
| ), |
There was a problem hiding this comment.
I like the feature idea, but I hate that all this code is duplicated!
There was a problem hiding this comment.
I totally agree, I couldn't find a way to make it more concise since the class names and text content had to be different for each link element. Maybe someone more experienced can help me out.
Alternatively, adding text to each link for desktop and mobile might help solve the issue as originally suggested by @kuba-orlik
|
This is a great change. If you can't spare the bandwidth to see it through let us know and maybe someone else can pick it up. |
awestm
force-pushed
the
profile-actions-popup
branch
from
4435dac
to
80924eb
Compare
Thanks, I just made an attempt at refactoring this. Not sure if there's a nicer way to do this, I'm still new to Scala. Please let me know what you think, if this is a change that is needed I am very happy to continue to work on it. |
|
I have made some attempts to fix your pr @awestm . Linking a pr to your fork you might still need to make some changes to _show.scss |
No description provided.