Fix sorting and filtering studies #2362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, whenever you would use one of the filter or sort controls on the study page, it would reset the other one. That meant that it was impossible to view your own studies sorted by recently updated for example. This change preserves the filter when you change the sort and vice versa. Here's a video showing that the change works: https://d.rayll.com/i/xhN0OG/XRTuSzRk1a
|
Looks like a good bug fix to me 😃 thanks for contributing! I'm not really at liberty to merge this, I'll leave it to the maintainer (veloce). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whenever you would use one of the filter or sort controls on the study page, it would reset the other one. That meant that it was impossible to view your own studies sorted by recently updated for example. This change preserves the filter when you change the sort and vice versa. Here's a video showing that the change works:
Screen.Capture.on.2023-05-21.at.13-22-53.mov