win: added support NUMA configuration with multiple count CPU sockets (fix #3458) #4381
+67
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Apr 6, 2024
| @@ -1302,7 +1302,7 @@ enum { | |||
| UV_EXTERN int uv_thread_getpriority(uv_thread_t tid, int* priority); | |||
| UV_EXTERN int uv_thread_setpriority(uv_thread_t tid, int priority); | |||
|
|
|||
| UV_EXTERN unsigned int uv_available_parallelism(void); | |||
| UV_EXTERN unsigned int uv_available_cores(void); | |||
There was a problem hiding this comment.
Changing the public API is not an option.
| DWORD length = 0; | ||
| HMODULE kernel32 = GetModuleHandleW(L"kernel32.dll"); | ||
|
|
||
| glpie_t GetLogicalProcessorInformationEx = (glpie_t)GetProcAddress(kernel32, "GetLogicalProcessorInformationEx"); |
There was a problem hiding this comment.
See how we dynamically load other functions at startup instead.
| return 0; | ||
| } | ||
|
|
||
| buffer = malloc(length); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a board with NUMA and I noticed it myself that only 50% cpu util, although all two should be fully loaded at 100%.