win: change process startup style #4380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Windows documentation, SW_SHOWNORMAL should be used for newly spawned processes instead of SW_SHOWDEFAULT.
|
SW_SHOWDEFAULT has been libuv's default for over a decade so I'm not too keen on changing it unless there are really compelling reasons. It's almost certain someone somewhere relies on the current behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Windows documentation,
SW_SHOWNORMALshould be used for newly spawned processes instead ofSW_SHOWDEFAULT.Here it says about
STARTUPINFOWthatwShowWindow"can be any of the values that can be specified in the nCmdShow parameter for the ShowWindow function, except for SW_SHOWDEFAULT".Here, referring to
SW_SHOWNORMAL, it says that applications "should specify this flag when displaying the window for the first time".