-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a flag to the uv_spawn
to trigger UAC on Windows
#4296
base: v1.x
Are you sure you want to change the base?
Conversation
uv_spawn
to trigger UAC on Windows
@vtjnash done! PTAL |
Seems good to me, what do other libuv devs think? It is platform specific, but so are a lot of the existing flags here. It will need a test and addition to the docs. And some of the options should probably error if passed in combination with it, if the combination is not feasible. |
SGTM |
@vtjnash any ideas on how to test this? once you trigger the UAC on subprocess, you need user's interaction to either click allow or disallow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM at a quick glance. @vtjnash want to look this over one more time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking back my LGTM for the moment because it silently ignores stdio redirection and other options, doesn't it? Incompatible options should be errors instead.
Co-authored-by: Jameson Nash <[email protected]>
@bnoordhuis resolved, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some suggestions but it'd be good if @vtjnash takes another look as well.
Co-authored-by: Ben Noordhuis <[email protected]>
Co-authored-by: Ben Noordhuis <[email protected]>
Co-authored-by: Ben Noordhuis <[email protected]>
Hello, @vtjnash , could you please take a look? |
This PR handles
UV_PROCESS_WINDOWS_HIDE_CONSOLE
andUV_PROCESS_WINDOWS_HIDE
UV_PROCESS_WINDOWS_HIDE_GUI
andUV_PROCESS_WINDOWS_HIDE
other flags ARE ignored silently due to
ShellExecuteExW
limitationsREFS
closes: #4295