Increase the retry delay and add retries count to avoid flaky "tcp_connect_timeout" test #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyad-elabid-nw
changed the title
|
This is a flaky test on qemu buildbots, i added more delay and retries counting before printing the error : "Network unreachable after multiple retries." |
|
Thanks for the pull request but I don't think it's quite ready for merging yet. For one, I would really look to know why the test got flaky all of a sudden. Is it because of a regression in libuv, a change in qemu, something else? I don't like making changes when the underlying cause isn't understood. |
|
Hello @bnoordhuis, thanks for replying, It's probably related to unstable network conditions during the connection, i'm going to investigate more the cause of the flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.