feat: Add a flag to the uv_spawn to trigger UAC on Windows
#4296
Conversation
CGQAQ
changed the title
uv_spawn to trigger UAC on Windows
|
@vtjnash done! PTAL |
|
Seems good to me, what do other libuv devs think? It is platform specific, but so are a lot of the existing flags here. It will need a test and addition to the docs. And some of the options should probably error if passed in combination with it, if the combination is not feasible. |
SGTM |
@vtjnash any ideas on how to test this? once you trigger the UAC on subprocess, you need user's interaction to either click allow or disallow |
There was a problem hiding this comment.
Thanks, LGTM at a quick glance. @vtjnash want to look this over one more time?
Co-authored-by: Jameson Nash <[email protected]>
|
@bnoordhuis resolved, PTAL |
There was a problem hiding this comment.
LGTM with some suggestions but it'd be good if @vtjnash takes another look as well.
Co-authored-by: Ben Noordhuis <[email protected]>
Co-authored-by: Ben Noordhuis <[email protected]>
Co-authored-by: Ben Noordhuis <[email protected]>
|
Hello, @vtjnash , could you please take a look? |
This PR handles
UV_PROCESS_WINDOWS_HIDE_CONSOLEandUV_PROCESS_WINDOWS_HIDEUV_PROCESS_WINDOWS_HIDE_GUIandUV_PROCESS_WINDOWS_HIDEother flags ARE ignored silently due to
ShellExecuteExWlimitationsREFS
closes: #4295