-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emscripten platform to makefile #14
base: main
Are you sure you want to change the base?
Conversation
Should this be filed against @schellingb ’s repository or this fork? |
Hi, @schellingb over to you. |
Given libretro/RetroArch#15033 this may work much better! I didn’t realize at the time that the pthread builds weren’t as well supported on the RA side. Is there a way to force RA to build dosbox with pthreads on? |
DOSbox just hangs without them. Note that RA should be built using pthread=4 or whatever.
Hi, I tested this on our buildbot - it doesn't compile - https://git.libretro.com/libretro/dosbox-pure/-/jobs/3284326 |
Is there a way to tell the buildbot to compile this core with pthread=2 or pthread=4? This core seemingly won’t work without threads because of how it connects libretro api with the dosbox system. |
That said, I was seeing weird phenomena like DOS out of memory errors for Commander Keen 1 and freezes for Keen 4 and Wolf3D, and I’m not familiar enough with the dosbox code to make attempts at diagnosing those. So let’s disable dosbox-pure for emscripten even though it does compile, unless someone can own the fixes. |
This seems to allow dosbox-pure to build on the emscripten platform. The core begins to load but doesn't seem to fully work in a browser; that said, I can't really get any Emscripten core I've compiled myself to work in a browser outside of the official release packages. So it might be working, but I can't figure out how to test it properly.