Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptive Frames: Relax savestate requirement to 'serialized' #14896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neil4
Copy link
Contributor

@neil4 neil4 commented Jan 24, 2023

Description

Draft PR for testing Preemptive Frames with its savestate requirement relaxed from 'deterministic' to 'serialized'. This makes it available to cores which likely have never been tested before with RunAhead (or Preemptive Frames).

Cores especially worth testing for speed are Beetle PSX HW, Parallel N64, Mupen, and Beetle Saturn.

Reviewers

@LibretroAdmin

@LibretroAdmin LibretroAdmin marked this pull request as ready for review January 24, 2023 04:36
@hizzlekizzle
Copy link
Contributor

Many cores "work" with runahead with serialized states, too, but you can get weird rollback divergence effects due to the lack of determinism, so we disable it to be extra-safe. I don't know if this is also the case with preemptive frames, but it's something to look out for.

@Tatsuya79
Copy link
Contributor

I suggest this instead: #14906

A simple setting to allow every experimentation, disregarding the info files.

@neil4 neil4 closed this Jan 27, 2023
@neil4 neil4 deleted the preemptive-frames-serialized-savestates branch January 27, 2023 04:26
@neil4 neil4 restored the preemptive-frames-serialized-savestates branch January 28, 2023 14:02
@neil4 neil4 reopened this Jan 28, 2023
@neil4
Copy link
Contributor Author

neil4 commented Jan 28, 2023

Reopening - I mistook #14906 to be a replacement for this PR. Depending on how testing goes, it might make sense to change preemptive frames' default requirement.

@LibretroAdmin
Copy link
Contributor

Hi @neil4 , sorry for taking almost a year for this PR. If we can resolve the merge conflict I'd be happy to merge this now.

Again, my bad, feel very bad for letting this PR languish for so long but would be totally willing to fasttrack it now.

@neil4
Copy link
Contributor Author

neil4 commented Sep 11, 2024

No worries, I'll look at this again pretty soon. I've also made a few updates recently to preemptive frames that I need to bring over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants