PWX-21520 : Add custom namespace during configmap creation #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrevanna
reviewed
Jul 10, 2023
| @@ -72,11 +72,12 @@ type k8sStore struct { | |||
|
|
|||
| // NewK8sStore returns a Store implementation which uses | |||
| // k8s configmaps to store data. | |||
| func NewK8sStore(clusterID string) (Store, configmap.ConfigMap, error) { | |||
| func NewK8sStore(clusterID, ns string) (Store, configmap.ConfigMap, error) { | |||
There was a problem hiding this comment.
nit: Can we call this pxNs?
Can we modify all references to namespace to indicate that it's PX's namespace that we are passing?
| @@ -90,6 +91,7 @@ func newK8sStoreWithParams( | |||
| name string, | |||
| lockTryDuration time.Duration, | |||
| lockTimeout time.Duration, | |||
| ns string, | |||
| @@ -99,6 +101,7 @@ func newK8sStoreWithParams( | |||
| lockAttempts, | |||
| 0, | |||
| 0, | |||
| ns, | |||
| @@ -61,7 +61,7 @@ type VirtualDisk struct { | |||
| } | |||
|
|
|||
| // NewClient creates a new vsphere cloudops instance | |||
| func NewClient(cfg *VSphereConfig, storeParams *store.Params) (cloudops.Ops, error) { | |||
| func NewClient(cfg *VSphereConfig, storeParams *store.Params, namespace string) (cloudops.Ops, error) { | |||
There was a problem hiding this comment.
nit: namespace -> pxNamespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://portworx.atlassian.net/browse/PWX-21520
Changes done :
Version of sched-ops is changed to latest commit hash of portworx/sched-ops#320. Because of that, other versions were also required to be updated for compatibility.
P.S : Need to update cloudops version in "porx" go.mod after this PR is merged.