Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shell detection #3565

Merged
merged 1 commit into from May 13, 2024
Merged

fix shell detection #3565

merged 1 commit into from May 13, 2024

Conversation

mo271
Copy link
Member

@mo271 mo271 commented May 8, 2024

Attempt to fix #3564

@mo271
Copy link
Member Author

mo271 commented May 8, 2024

The idea with this regular expression is to also match dash sh, zsh and so on...

@mo271 mo271 requested a review from eustas May 8, 2024 07:22
@mo271 mo271 enabled auto-merge May 8, 2024 09:23
@Patterner
Copy link

it works, but i'm not really liking it. it's way too vague. and i'm not really sure why this there.

i would've done something like
^/(/usr)?/bin/env .*sh)|(/usr/)?/bin/.*sh$
i.e /usr/bin/env dash /bin/env zsh /bin/zsh /usr/bin/fish

*sh matches ssh and texhash

if it's MSYS2 deal with it otherwise just use "a2x" as it is.

@eustas
Copy link
Contributor

eustas commented May 13, 2024

Provided regexp also matches /usr/bin/ssh and /usr/bin/env texhash. So let's keep it simple, and rely on sanity of package developers.

@mo271 mo271 added this pull request to the merge queue May 13, 2024
Merged via the queue into libjxl:main with commit aeab041 May 13, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a2x Syntax Error with .asdf/PyEnv
3 participants