Set PKGCONFIG_TARGET_LIBS/INCLUDES for libjxl_cms.pc #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo271
previously approved these changes
Oct 24, 2023
|
Thanks! |
|
Please add yourself to the AUTHORS file (I can also do it for you, if that is more convenient...) |
|
Thanks for attempting to fix the AUTHORS check! They still fail, because a different name/email address are used in the commits, see here: https://github.com/libjxl/libjxl/commit/2b680c3a7c2b05db2e322a2900beb226b272d866.patch |
|
Should be fixed now, hopefully. |
|
I believe it is better to move this piece to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the .pc file ends up with those variables empty, breaking the build in hilarious ways as the empty -L / -I eat up the next argument.
This section is straight up copied from the two sibling .cmake files.