Add tree_at similar to blob_at #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Returns a String. | ||
| def tree_at(revision, path) | ||
| tree = Rugged::Commit.lookup(self, revision).tree | ||
| tree.path(path)[:oid] |
There was a problem hiding this comment.
The way this is implemented right now, #tree_at would return the tree's oid, not the actual Rugged::Tree object. This is different from how #blob_at works.
Would you mind fixing this up and adding some test cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if a
tree_atmethod would be useful (similar to theblob_at? (I'm only recently exploring rugged's source, so I could be wrong). It's not a lot of effort doing that otherwise, but a method for that could keep things easy.There isn't much error handling atm.