Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend to None while ffmpeg is unavailable. #1392

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

pengzhendong
Copy link
Contributor

Before:

Screenshot 2024-09-14 at 18 34 15

After:

Screenshot 2024-09-14 at 18 35 08

@pzelasko
Copy link
Collaborator

Wait, that's weird. This code is guarded by if torchaudio_ffmpeg_backend_available(): so it shouldn't have entered this branch at all. Perhaps you could move this extra logic inside torchaudio_ffmpeg_backend_available instead? Looks like the check there may be insufficient.

@pzelasko pzelasko added this to the v1.28.0 milestone Sep 17, 2024
@pengzhendong
Copy link
Contributor Author

pengzhendong commented Sep 18, 2024

If it is moved to torchaudio_ffmpeg_backend_available, Lhotse will utilize torchaudio.StreamReader to read the audio instead of torchaudio.info.

ImportError: Failed to initialize the FFmpeg extension. Tried versions: ['6', '5', '4', '']. Enabling DEBUG logging will provide more details about the error.

@pzelasko
Copy link
Collaborator

pzelasko commented Oct 1, 2024

I'm still not quite sure what's going on but your change seems unlikely to break anything and the backward compatibility tests are passing. LGTM, thanks!

@pzelasko pzelasko enabled auto-merge (squash) October 1, 2024 22:36
@pzelasko pzelasko disabled auto-merge October 1, 2024 22:36
@pzelasko pzelasko merged commit a31a532 into lhotse-speech:master Oct 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants