uefi : fix broken build due to missing edk2 submodule #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
reviewed
Nov 7, 2024
This change updates EDK2 to stable202408.01. This is a minor update with only one additonal commit compared the previous version which fixes missing subhook submodule issue by switching to TianoCore mirror. Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
uefi.edk2-stable202408.01
branch
from
b4ece82
to
c240f5d
Compare
OhmSpectator
approved these changes
Nov 7, 2024
|
Hm... In theory, the tests should have success, then... And they are still red =( |
|
@shjala, ah, you also have to upgrade the Docker files, where we specify the hash for the eve-eufi package. It's xen-tools and something else... |
This has nothing to do with the EVE stucking at boot in Eden, this just fixes building EDK2 from source which is broken (even old versions are broken). |
|
@shjala but we still have to update the hashes in the dependent Dockerfiles... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates EDK2 to stable202408.01. This is a minor update with only one additional commit compared the previous version which fixes missing subhook submodule issue by switching to TianoCore mirror.
tianocore/edk2@edk2-stable202408...edk2-stable202408.01
For the curios, Adding a patch to fix the issue is not straightforward because the docker ADD command clones the repository and initializes the submodules at once (before applying any patches).