-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Descheduler, fix startup readywait #4363
Open
andrewd-zededa
wants to merge
1
commit into
lf-edge:master
Choose a base branch
from
andrewd-zededa:andrewd-external-boot-image-import
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Install Descheduler, fix startup readywait #4363
andrewd-zededa
wants to merge
1
commit into
lf-edge:master
from
andrewd-zededa:andrewd-external-boot-image-import
+4,903
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewd-zededa
force-pushed
the
andrewd-external-boot-image-import
branch
from
October 16, 2024 23:29
e65e8f3
to
0d2bd18
Compare
andrewd-zededa
force-pushed
the
andrewd-external-boot-image-import
branch
from
October 16, 2024 23:39
0d2bd18
to
7748d16
Compare
rene
reviewed
Oct 18, 2024
andrewd-zededa
force-pushed
the
andrewd-external-boot-image-import
branch
2 times, most recently
from
October 18, 2024 21:22
75a35bd
to
7de9616
Compare
Rebased on master, addressed all review comments. |
@deitch updated PR description to add context. |
deitch
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions and possible suggestions.
andrewd-zededa
force-pushed
the
andrewd-external-boot-image-import
branch
7 times, most recently
from
October 23, 2024 14:53
dcf4165
to
d5098b7
Compare
Descheduler will be used for eve-app rebalancing during cluster node reboots/upgrades in an upcoming PR. Wait for longhorn daemonsets to be ready, before upcoming PR to snapshot single-node /var/lib kube db. Resolve sometimes failure to import external-boot-image Wait for containerd before importing. Tighter error checking on import. Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
andrewd-external-boot-image-import
branch
from
October 23, 2024 15:06
d5098b7
to
87f6a27
Compare
deitch
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few changes to the cluster-init.sh install/boot path of HV=kubevirt eve as a base for upcoming cluster work.
Descheduler will be used for eve-app rebalancing during cluster node reboots/upgrades in an upcoming PR. After a node has encountered an outage and recovered the descheduler is used to evict pods where the current node does not match the preferred affinity node. Next the native kubernetes scheduler is allowed to run again and place that pod back where it has requested placement.
Longhorn daemonsets take some time to come ready (~5-10 minutes on some systems) after the initial install request with 'kubectl apply'. It is important to wait at install time and block all_components_initialized until all longhorn daemonsets are ready as a foundation before an upcoming PR to snapshot single-node /var/lib sqlite k3s db. This db snapshot is used to facilitate converting a cluster node back to a single node system.
Fix: Resolve a small window which led to a failure to import external-boot-image: