Use trap method instead of pcntl_signal for better signal handling #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the direct use of
pcntl_signal
with thetrap
method provided by theInteractsWithSignals
trait in theTopCommand
class. Thetrap
method allows for multiple handlers for the same signal, preventing potential issues in environments like Laravel Octane where multiple handlers might be necessary.Changes
pcntl_signal(SIGINT, function () use ($guiBuilder) { ... });
with$this->trap(SIGINT, function () use ($guiBuilder) { ... });
Benefits
Testing
SIGINT
.