feat: use token limits in core memory instead of character limits #2081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2000 tokens is a good starting point? (~8k chars)
Pending design decision:
Block.tokenizer_model
nullable /Optional[str]
, orstr
with a default imported fromconstants.py
?constants.DEFAULT_TOKENIZER_MODEL
ifself.tokenizer_model is None
self.tokenizer_model
will beconstants.DEFAULT_TOKENIZER_MODEL
tokenizer_model
inside ofmetadata_
?TODOs for later PR:
tokenizer_model
in theMemory
class to be drawn fromagent.llm_config.model
agent.llm_config.model
is changed, thememory.tokenizer_model
is changed too