fix: Update grammar generator and Fixes "None" model in chat_completion_proxy #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximilian-Winter
changed the title
Maximilian-Winter
changed the title
cpacker
reviewed
Apr 3, 2024
| processed_models, | ||
| created_rules, | ||
| field_info=None, | ||
| ) -> tuple[str, list[str]]: |
There was a problem hiding this comment.
Is there a reason to go from Tuple to tuple?
Why not Tuple[str, List[str]]?
There was a problem hiding this comment.
No I think some kind of formatter did that. I just copied the updated grammar generator from my llama-cpp-agent framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Update the grammar generator to contain fixes and additional functionality. And fixes possible none value of the model in chat_completion_proxy
How to test
Use a local llm with grammar wrapper
Is your PR over 500 lines of code?
No