Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated WFE.RedeemNonceServices #7493

Merged
merged 5 commits into from
May 21, 2024
Merged

Remove deprecated WFE.RedeemNonceServices #7493

merged 5 commits into from
May 21, 2024

Conversation

aarongable
Copy link
Contributor

Fixes #6610

@aarongable aarongable requested a review from a team as a code owner May 17, 2024 20:04
@aarongable aarongable requested a review from pgporada May 17, 2024 20:04
pgporada
pgporada requested changes May 17, 2024
View reviewed changes
Copy link
Member

@pgporada pgporada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a more thorough review come Monday morning.

cmd/nonce-service/main.go Outdated Show resolved Hide resolved
@aarongable aarongable requested a review from pgporada May 20, 2024 18:19
pgporada
pgporada reviewed May 20, 2024
View reviewed changes
cmd/nonce-service/main.go Outdated Show resolved Hide resolved
@aarongable @pgporada
Comment
3e3ef85 
Co-authored-by: Phil Porada <[email protected]>
@aarongable aarongable requested a review from pgporada May 20, 2024 19:03
@beautifulentropy beautifulentropy self-requested a review May 21, 2024 15:40
@beautifulentropy
Copy link
Member

Checked in with the folks at Fastly and they've fully moved over.

pgporada
pgporada previously approved these changes May 21, 2024
View reviewed changes
beautifulentropy
beautifulentropy requested changes May 21, 2024
View reviewed changes
cmd/nonce-service/main.go Show resolved Hide resolved
wfe2/wfe_test.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@letsencrypt letsencrypt deleted a comment from github-actions bot May 21, 2024
@pgporada pgporada merged commit 5be3650 into main May 21, 2024
14 checks passed
@pgporada pgporada deleted the better-wfe-sa-mock branch May 21, 2024 17:13
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
@aarongable
Remove deprecated WFE.RedeemNonceServices (letsencrypt#7493)
5fde9bb 
Fixes letsencrypt#6610
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 31, 2024
@aarongable
Remove deprecated WFE.RedeemNonceServices (letsencrypt#7493)
3557378 
Fixes letsencrypt#6610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgporada pgporada pgporada approved these changes

@beautifulentropy beautifulentropy beautifulentropy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WFE: Deprecate RedeemNonceServices configuration and code paths
3 participants
@aarongable @beautifulentropy @pgporada