Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): flush output before exiting #3971

Merged
merged 1 commit into from Mar 15, 2024

Conversation

smerrill
Copy link
Contributor

@smerrill smerrill commented Mar 9, 2024

Description

Fixes #3970.

Motivation and Context

Without this code, any code trying to consume the output of lerna list would only get the first 8k.

How Has This Been Tested?

It has not yet been tested other than the simple repro I put into #3970 .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry changed the title fix: flush list output before exiting fix(list): flush output before exiting Mar 15, 2024
@JamesHenry JamesHenry merged commit 6426da8 into lerna:main Mar 15, 2024
14 checks passed
@JamesHenry
Copy link
Member

Thanks a lot @smerrill!

@smerrill smerrill deleted the fix/list-command-truncated-output branch March 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lerna list output is truncated at 8192 bytes when execed
2 participants