Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #70

Merged
merged 2 commits into from Mar 13, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/momentum-modal.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "based/momentum-modal": "dev-l11-compatibility",
    }
}

Finally, run: composer update

Copy link

what-the-diff bot commented Mar 2, 2024

PR Summary

  • Support for Laravel 11 in Continuous Integration Workflow
    The CI workflow file has been updated to include Laravel 11 as an option. This enables developers to test code in this newer version of Laravel, enhancing adaptability with different versions of the framework.

  • Autoloaded Dev Section Added to composer.json
    A new autoload-dev section has been added to the composer.json file. With this change, developers can now automatically load specific sets of files when running in a development environment. This element improves workflow and efficiency.

  • Modifications to require-dev in composer.json
    The require-dev portion of the composer.json file has been updated. Used mainly for installing packages that aren't necessary in production but useful during development, this modification allows for a more streamlined and efficient development process.

@lepikhinb lepikhinb merged commit bb37602 into lepikhinb:master Mar 13, 2024
1 of 4 checks passed
@gainlinejono
Copy link

Has this release been tagged? When updating to L11 there's an issue with compatibility with this package using inertia v1.0

@lepikhinb
Copy link
Owner

@gainlinejono you should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants