Fix some more element definition issues

lemonmade · Sep 16, 2024 · ba5df0c · ba5df0c
1 parent 26d3eca
commit ba5df0c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/swift-kangaroos-argue.md b/.changeset/swift-kangaroos-argue.md
@@ -0,0 +1,7 @@
+---
+'@watching/clips-preact': patch
+'@watching/clips-react': patch
+'@watching/clips': patch
+---
+
+Fix some more element definition issues
diff --git a/packages/clips-preact/source/components/Action.tsx b/packages/clips-preact/source/components/Action.tsx
@@ -26,12 +26,13 @@ declare module 'preact' {
   }
 }
 
-export function Action({overlay, onPress, ...props}: ActionProps) {
+export function Action({overlay, children, onPress, ...props}: ActionProps) {
   return (
     <ui-action
-      {...props}
       onpress={onPress ? (event) => event.respondWith(onPress()) : undefined}
+      {...props}
     >
+      {children}
       {overlay && isValidElement(overlay)
         ? cloneElement(overlay, {slot: 'overlay'})
         : null}

diff --git a/packages/clips-react/source/components/Action.tsx b/packages/clips-react/source/components/Action.tsx
@@ -30,7 +30,7 @@ declare module 'react' {
 }
 
 export const Action = forwardRef<ActionElement, ActionProps>(function Action(
-  {overlay, onPress, ...props},
+  {overlay, children, onPress, ...props},
   ref,
 ) {
   return (
@@ -39,6 +39,7 @@ export const Action = forwardRef<ActionElement, ActionProps>(function Action(
       {...props}
       onpress={onPress ? (event) => event.respondWith(onPress()) : undefined}
     >
+      {children}
       {overlay && isValidElement(overlay)
         ? cloneElement<any>(overlay, {slot: 'overlay'})
         : null}

diff --git a/packages/clips/source/extension.ts b/packages/clips/source/extension.ts
@@ -14,6 +14,8 @@ import {
 } from './extension-points.ts';
 import {acceptSignals} from './signals.ts';
 
+import './elements.ts';
+
 customElements.define('remote-root', RemoteRootElement);
 customElements.define('remote-fragment', RemoteFragmentElement);