Feature/manage logging options #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add logger.conf.erb template for logging options
- add logger_options defaults to params.pp
- add asterisk::dotd resource for logger_options config file
- add logger_options parameter to init.pp - modify logger.conf.erb template to interpolate logger_options - add default log file and level mappings to logger.conf.erb template
|
This should be merged before I start version 2.x to migrate the codebase to puppet 4.x syntax in #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@archii has implemented managing logging options. this is interesting and I'd like to merge this code. I need to take some time to evaluate the changes to perform the merger!