Add build/lint workflows and fixes.

.ansible-lint

@@ -4,6 +4,8 @@ exclude_paths:
   - group_vars/*
   - hosts.yml
   - .ansible-lint
+  - sm_plugins/*
+  - playbooks/roles/githubixx.ansible_role_wireguard/*
 
 skip_list:
   - schema
@@ -16,6 +18,7 @@ skip_list:
   - risky-shell-pipe
   - name[casing]
   - name[play]
+  - ignore-errors
 
 kinds:
   - tasks: "*/tasks/*.yml"

.github/workflows/build.yml

@@ -4,24 +4,30 @@ on: [push, pull_request]
 
 jobs:
   lint:
-    runs-on: ubuntu-20.04
+    name: Ansible Lint
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-
-#  publish:
-#    runs-on: ubuntu-20.04
-#    needs: [lint]
-#    steps:
-#      - uses: actions/checkout@v2
-#
-#      - name: Build srcds image
-#        uses: arillso/action.playbook@master
+      - uses: actions/checkout@v4
+      - name: Run ansible-lint
+        uses: ansible/ansible-lint@main
+#        # optional (see below):
 #        with:
-#          limit: localhost
-#          vault_password: ${{ secrets.VAULT_SECRET}}
-#          playbook: playbooks/srcds_github.yml
-#          inventory: hosts.yml
-#          galaxy_file: collections/requirements.yml
-#        env:
-#          ANSIBLE_HOST_KEY_CHECKING: 'false'
-#          ANSIBLE_DEPRECATION_WARNINGS: 'false'
+#          args: ""
+#          setup_python: "true"
+#          working_directory: ""
+#          requirements_file: ""
+
+  sourcemod:
+    name: Build Plugins
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup SourcePawn Compiler
+        uses: rumblefrog/setup-sp@master
+        with:
+          version: "1.12.x"
+
+      - name: Ensure plugin builds
+        working-directory: ./sourcemod/scripting
+        run: ./compile.sh

.github/workflows/sourcemod.yml

@@ -0,0 +1,9 @@
+name: Build Sourcemod
+
+on:
+  push:
+  pull_request:
+
+permissions: write-all
+
+jobs:

Makefile

@@ -11,7 +11,7 @@ format:
 	@find ./roles/sourcemod/files/addons/sourcemod/scripting -regex '.*\.\(sp\)' -exec clang-format -style=file -i {} \;
 
 lint:
-	@ansible-lint
+	@ansible-lint --exclude sm_plugins watcher
 
 deps:
 	@ansible-galaxy collection install -r collections/requirements.yml

playbooks/roles/gbans/tasks/postgres.yml

@@ -55,16 +55,16 @@
       "-c", "password_encryption=md5",
       "-c", "max_connections=125",
       "-c", "shared_buffers=1GB",
-      #"-c", "effective_cache_size=6GB",
-      #"-c", "maintenance_work_mem=2GB",
+      # "-c", "effective_cache_size=6GB",
+      # "-c", "maintenance_work_mem=2GB",
       "-c", "checkpoint_completion_target=0.9",
       "-c", "wal_buffers=16MB",
       "-c", "default_statistics_target=100",
       "-c", "random_page_cost=1.1",
       "-c", "effective_io_concurrency=200",
       "-c", "work_mem=10485kB",
-      #"-c", "min_wal_size=1GB",
-      #"-c", "max_wal_size=4GB",
+      # "-c", "min_wal_size=1GB",
+      # "-c", "max_wal_size=4GB",
       "-c", "max_worker_processes=8",
       "-c", "max_parallel_workers_per_gather=4",
       "-c", "max_parallel_workers=8",

playbooks/roles/gbans/tasks/tf2bdd.yml

@@ -21,4 +21,4 @@
       logging_jobname: "containerlogs"
     networks:
       - name: caddy_net
-  ignore_errors: true
+ # ignore_errors: true

playbooks/roles/metrics/tasks/grafana.yml

@@ -101,4 +101,3 @@
       - 127.0.0.1:3000:3000
   tags:
     - grafana
-

playbooks/roles/metrics/tasks/loki.yml

@@ -39,4 +39,3 @@
       - "{{ vpn_hosts[metrics_hostname].ip }}:3100:3100"
   tags:
     - loki
-

playbooks/roles/metrics/tasks/main.yml

@@ -30,7 +30,7 @@
   tags:
     - metrics-server
 
-#- name: mimir
+# - name: mimir
 #  import_tasks: mimir.yml
 #  tags:
 #    - metrics-server

playbooks/roles/metrics/tasks/mimir.yml

@@ -24,7 +24,7 @@
     restart: true
     purge_networks: true
     restart_policy: unless-stopped
-    command: [ "--config.file=/etc/mimir.yml" ]
+    command: ["--config.file=/etc/mimir.yml"]
     labels:
       logging: "promtail"
       logging_jobname: "containerlogs"

playbooks/roles/metrics/tasks/minio.yml

@@ -26,5 +26,5 @@
     volumes:
       - minio-data:/data
     ports:
-      #- 127.0.0.1:9000:9000
+      # - 127.0.0.1:9000:9000
       - "9001:9001"

playbooks/roles/metrics/tasks/promtail.yml

@@ -1,6 +1,6 @@
 ---
 
-#- name: Enable rsyslog
+# - name: Enable rsyslog
 #  ansible.builtin.include_role:
 #    name: hadret.rsyslog
 

playbooks/roles/metrics/tasks/tempo.yml

@@ -16,7 +16,7 @@
   docker_container:
     name: tempo
     image: grafana/tempo:latest
-    command: [ "-config.file=/etc/tempo.yml" ]
+    command: ["-config.file=/etc/tempo.yml"]
     restart: true
     pull: true
     purge_networks: true

playbooks/roles/sourcemod/tasks/main.yml

@@ -16,14 +16,14 @@
     src: "{{ metamod_download|default(\"https://mms.alliedmods.net/mmsdrop/1.12/mmsource-1.12.0-git1194-linux.tar.gz\") }}"
     dest: ~/build_sourcemod/
     remote_src: true
-    #creates: ~/build_sourcemod/addons/metamod
+    # creates: ~/build_sourcemod/addons/metamod
 
 - name: Download latest sourcemod
   ansible.builtin.unarchive:
     src: "{{ sm_download|default(\"https://sm.alliedmods.net/smdrop/1.12/sourcemod-1.12.0-git7137-linux.tar.gz\") }}"
     dest: ~/build_sourcemod/
     remote_src: true
-    #creates: ~/build_sourcemod/addons/sourcemod
+    # creates: ~/build_sourcemod/addons/sourcemod
 
 - name: Copy extensions & plugin sources [remote]
   when: inventory_hostname != "localhost"
@@ -47,4 +47,4 @@
     chdir: ~/build_sourcemod/addons/sourcemod/scripting
     cmd: bash build.sh
   tags:
-    - game_config
+    - game_config

playbooks/roles/srcds/tasks/main.yml

@@ -9,7 +9,7 @@
   unarchive:
     src: https://steamcdn-a.akamaihd.net/client/installer/steamcmd_linux.tar.gz
     dest: ~/steamcmd
-    remote_src: yes
+    remote_src: true
     creates: ~/steamcmd/steamcmd.sh
 
 - name: steamcmd update script
@@ -80,7 +80,7 @@
   loop: "{{ services }}"
   when: item.config == "pve"
   # Perform the copy from the *remote* sourcemod build output
-  #delegate_to: "{{ inventory_hostname }}"
+  # delegate_to: "{{ inventory_hostname }}"
 
 - name: Copy attach.sh
   ansible.builtin.copy:
@@ -105,7 +105,7 @@
     src: curated_maplist.txt.j2
     dest: ~/srcds-{{ item.server_name_short }}/tf/addons/sourcemod/configs/curated_maplist.txt
     mode: 0655
-  when: item.curated_pool != ""
+  when: item.curated_pool
   tags:
     - game_config
   loop: "{{ services }}"
@@ -482,4 +482,4 @@
   loop_control:
     index_var: loop0
   when: ansible_distribution == 'Ubuntu'
-  tags: cron
+  tags: cron

playbooks/system.yml

@@ -61,14 +61,14 @@
           - python3-netaddr
 
     - name: Install xanmod-rt-v2
-      when: old_cpu == true
+      when: old_cpu
       ansible.builtin.apt:
         state: present
         pkg:
           - linux-xanmod-rt-x64v2
 
     - name: Install xanmod-rt-v3
-      when: old_cpu == false
+      when: not old_cpu
       ansible.builtin.apt:
         state: present
         pkg:

playbooks/update_srcds.yml

@@ -3,4 +3,3 @@
   hosts: tf2
   roles:
     - srcds
-    - tf2

requirements.yml

@@ -3,4 +3,4 @@ collections:
   - community.general
   - community.docker
   - ansible.posix
-  - githubixx.ansible_role_wireguard
+