Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lake: properly prepend job log in ensureJob #6291

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Dec 2, 2024

This PR ensures the the log error position is properly preserved when prepending stray log entries to the job log. It also adds comparison support for Log.Pos.

@tydeu tydeu added the changelog-lake Lake label Dec 2, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 2, 2024

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-11-30 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-12-02 22:26:15)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-02 23:41:13)

@tydeu tydeu marked this pull request as ready for review December 2, 2024 23:20
@tydeu tydeu enabled auto-merge December 2, 2024 23:20
@tydeu tydeu added this pull request to the merge queue Dec 2, 2024
Merged via the queue into leanprover:master with commit f6bc6b2 Dec 3, 2024
15 checks passed
@tydeu tydeu deleted the lake/prepend-log branch December 3, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants