Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing (type := true) in reader monad example #6196

Merged
merged 1 commit into from
Dec 7, 2024
Merged

doc: missing (type := true) in reader monad example #6196

merged 1 commit into from
Dec 7, 2024

Conversation

jsr-p
Copy link
Contributor

@jsr-p jsr-p commented Nov 24, 2024

This PR adds missing (types := true) to #reduce example in Readers example. Since 4.10 the (types := true) is necessary for the ReaderM Environment String type to be reduced into Environment → String.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 24, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 24, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4e885be96d82c522af4acb9ce9afe77e5aea7feb --onto ba3f2b3ecf8967410f3498e2835b883601f03967. (2024-11-24 10:15:10)
  • ✅ Mathlib branch lean-pr-testing-6196 has successfully built against this PR. (2024-11-25 08:09:42) View Log

@jsr-p jsr-p force-pushed the fix-missing-reduce branch from 0393ef9 to 8181615 Compare November 25, 2024 07:04
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6196
37d238c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6196
1d50768
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 25, 2024
@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Dec 6, 2024
@Kha Kha changed the title fix: missing (type := true) in reader monad example doc: missing (type := true) in reader monad example Dec 7, 2024
@Kha Kha enabled auto-merge December 7, 2024 15:59
@Kha Kha added this pull request to the merge queue Dec 7, 2024
Merged via the queue into leanprover:master with commit 762c575 Dec 7, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsr-p @leanprover-community-bot @Kha @leanprover-bot