feat: add BitVec.[toNat|toInt|toFin|getLsbD|getMsbD|getElem|msb]_fill #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog-library |
tobiasgrosser
force-pushed
the
bv_fill
branch
from
c23c0c8
to
c5cc20c
Compare
This PR implements BitVec.[*]_fill.
tobiasgrosser
force-pushed
the
bv_fill
branch
from
c5cc20c
to
b6a7862
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
kim-em
reviewed
Nov 23, 2024
Comment on lines
+2252
to
+2253
| theorem fill_eq {w : Nat} {v : Bool} : fill w v = if v = true then allOnes w else 0#w := by | ||
| by_cases h : v <;> (simp only [h] ; ext ; simp) |
There was a problem hiding this comment.
Can we have two simp lemmas fill_true and fill_false?
|
An alternative approch here might be to deprecate/delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
BitVec.*_fill.