Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change bv_decide to an elaborated config #6010

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Nov 8, 2024

This PR changes bv_decide's configuration from lots of set_option to an elaborated config like simp or omega. The notable exception is sat.solver which is still a set_option such that users can configure a custom SAT solver globally for an entire project or file. Additionally it introduces the ability to set maxSteps for the simp preprocessing run through the new config.

The latter feature was requested by people using bv_decide on SMTLIB which has ginormous terms that exceed the default.

@hargoniX hargoniX added the changelog-language Language features, tactics, and metaprograms label Nov 8, 2024
@hargoniX hargoniX force-pushed the hbv/bv_decide_config branch from b6e610d to 89b303a Compare November 8, 2024 10:25
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 8, 2024 10:33 Inactive
@hargoniX hargoniX force-pushed the hbv/bv_decide_config branch from 897d917 to 8ac05e9 Compare November 8, 2024 10:40
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 8, 2024 10:48 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 8, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9b167e20512640afbee5777462fa50ddb2e778d5 --onto c779f3a039963fd38b03a78f635f0a7c36f24f42. (2024-11-08 11:09:59)

@hargoniX hargoniX added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 837a67b Nov 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants