Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omega to abstract its own proofs #5998

Closed
wants to merge 1 commit into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Nov 7, 2024

This PR is an experiment.

Some experiments show that abstracting the proofs produced by omega can
speed up a particularly gnarly proof from 15s to 10s. Not a
game-changer, but still notable.

It seems this breaks the use of omega as a simp discharger. Are simp
dischargers not allowed to write auxillary definitions to the
environment?

This PR is an experiment.

Some experiments show that abstracting the proofs produced by omega can
speed up a particularly gnarly proof from 15s to 10s. Not a
game-changer, but still notable.

It seems this breaks the use of `omega` as a simp discharger. Are simp
dischargers not allowed to write auxillary definitions to the
environment?
@nomeata nomeata added the changelog-no Do not include this PR in the release changelog label Nov 7, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 7, 2024
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Nov 7, 2024
@nomeata nomeata closed this Nov 8, 2024
@nomeata nomeata deleted the joachim/omega-abstract-proofs branch November 8, 2024 14:01
@nomeata nomeata restored the joachim/omega-abstract-proofs branch November 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants