-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: message kinds #5945
feat: message kinds #5945
Conversation
Mathlib CI status (docs):
|
This is the first step for a potential solution to #5194. An alternative solution would be to collect all tags within a message and serialize them. However, as the goal here is to be able to identify messages by name to customize reporting, it is not clear how this would work in a multiple tag case. Hence, the approach here is restricted to a single "message kind". A tags field can be added in the future should a more appropriate use case emerge. |
If it's always inferred, why is it a field? |
@Kha It is a field so that it will be part of |
Oh you mean it is there for |
Good idea! For some reason it did not occur to me that Separately, the odd JSON encoding of a anonymous kind has led me to propose #5980. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a new definition
Message.kind
which returns the top-level tag of a message. This is serialized as the new fieldkind
inSerialMessaege
so that i can be used by external consumers (e.g., Lake) to identify messages vialean --json
.The tag of trace messages has also been changed from
_traceMsg
to the more friendlytrace
.