Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify keys method on HashMaps #5866

Merged
merged 18 commits into from
Nov 8, 2024

Conversation

monsterkrampe
Copy link
Contributor

@monsterkrampe monsterkrampe commented Oct 28, 2024

This PR verifies the keys function on Std.HashMap.


Initial discussions have already happend with @TwoFX and we are collaborating on this matter.
This will remain a draft as long as not all desired results have been added.

If we should still create an issue for the topic of this PR, let us know.
Of course, any other feedback is appreciated as well :)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 28, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 62521f4f2d12ad239644e160dfdc5bd4d34d3f1b --onto 9847923f9be5de968f10ed7c7493e3ca0072abce. (2024-10-28 15:44:59)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 62521f4f2d12ad239644e160dfdc5bd4d34d3f1b --onto c779f3a039963fd38b03a78f635f0a7c36f24f42. (2024-11-05 17:43:47)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 345ecd20c9d8c435fd1ac05d4a239af170f76f7a --onto c779f3a039963fd38b03a78f635f0a7c36f24f42. (2024-11-06 16:23:08)

@TwoFX TwoFX self-assigned this Oct 29, 2024
@monsterkrampe monsterkrampe marked this pull request as ready for review November 6, 2024 09:58
@monsterkrampe
Copy link
Contributor Author

I think this is ready for review now.
Let us know if other results around keys would be expected :)

Also, I'm currently not sure why one of the tests fails. Maybe this would be resolved by a rebase...

Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@TwoFX TwoFX enabled auto-merge November 8, 2024 07:04
@TwoFX TwoFX added this pull request to the merge queue Nov 8, 2024
Merged via the queue into leanprover:master with commit 9b167e2 Nov 8, 2024
14 checks passed
@monsterkrampe monsterkrampe deleted the hashmap-keys branch November 8, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants