Update README.md #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Brief instructions on how to use nightlies in `lean-toolchain`. * Pointer to https://leanprover-community.github.io/contribute/tags_and_branches.html with even more details.
kim-em
reviewed
Jul 6, 2024
README.md
Outdated
Comment on lines
5
to
8
| You should not need to use this repository directly. Instead: | ||
| * Once your Lean pull request has the [`toolchain-available`](https://github.com/leanprover/lean4/pulls?q=is%3Apr+is%3Aopen+label%3Atoolchain-available) label, | ||
| * Edit the `lean-toolchain` file in the project you would like to test your pull request in to say: | ||
| `leanprover/lean4:nightly-YYYY-MM-DD`, where `YYYY-MM-DD` is the date of the nighly you want to use (e.g. `2023-11-01`). |
There was a problem hiding this comment.
No, this isn't right. The toolchain-available label is referring to the availability of the lean-pr-testing-NNNN toolchain over at the lean4-pr-releases repository, not about the nightlies.
There was a problem hiding this comment.
I think to see if a PR has made it into a nightly one needs to look at the release notes on this repository.
There was a problem hiding this comment.
Hmm, I don't remember how these sentences ended up in this PR...
jcommelin
commented
Jul 9, 2024
README.md
Outdated
Comment on lines
5
to
8
| You should not need to use this repository directly. Instead: | ||
| * Once your Lean pull request has the [`toolchain-available`](https://github.com/leanprover/lean4/pulls?q=is%3Apr+is%3Aopen+label%3Atoolchain-available) label, | ||
| * Edit the `lean-toolchain` file in the project you would like to test your pull request in to say: | ||
| `leanprover/lean4:nightly-YYYY-MM-DD`, where `YYYY-MM-DD` is the date of the nighly you want to use (e.g. `2023-11-01`). |
There was a problem hiding this comment.
Hmm, I don't remember how these sentences ended up in this PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lean-toolchain.