fix: handle arguments and defaults consistently #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default function arguments were not being handled the same way as function arguments. It was possible that an expression that could be passed as an argument could not have been used as a default value for the same argument. This patch fixes this issue, and simplifies some of the parsing code for arguments and function signatures.
|
Could you give an example of
|
seanmcl
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default function arguments were not being handled the same way as function arguments. It was possible that an expression that could be passed as an argument could not have been used as a default value for the same argument. This patch fixes this issue, and simplifies some of the parsing code for arguments and function signatures.