refactor: rename Tactic.sym.debug traceclass to avoid confusion with the option of the same name.
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the option of the same name. We pick `Tactic.sym.info` to be consistent with the `simp_mem.info` traceclass. Also, we rename `withVerboseTraceNode` to `withInfoTraceNode` to explicitly refer to the new name, and ensure it uses the right trace class (rather than the non-existent `Tactic.sym.verbose`)
alexkeizer
force-pushed
the
rename-sym-debug
branch
from
7ab328d to
1b2f627
Compare
shigoel
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We rename
Tactic.sym.debugtoTactic.sym.infoto be consistent with thesimp_mem.infotraceclass. Also, we renamewithVerboseTraceNodetowithInfoTraceNodeto explicitly refer to the new name, and ensure it uses the right trace class (rather than the non-existentTactic.sym.verbose)Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.