refactor: extract out MemoryEffects structure
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This extracts the purely non-functional refactor from #179. I've stacked this PR on top of #220 to make use of the common tracing methods we've already added at some point in that stack, so this version of the change resolves all comment that were made on the previous PR, and is ready to merge from my perspective. |
shigoel
reviewed
Oct 8, 2024
alexkeizer
force-pushed
the
section-monad
branch
from
fa4030e to
90cae6e
Compare
shigoel
previously approved these changes
Oct 8, 2024
alexkeizer
force-pushed
the
extract-memory-effects
branch
from
077b5da to
6295e15
Compare
|
@shigoel All comment address, this should be ready to merge |
shigoel
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Extracted from #179, stacked on #220.
We extract out memory-effects related code from AxEffects into a new MemoryEffects structure. This PR is purely a non-functional change, but will serve as the starting point of integrating simp_mem with sym_n.
The current simplification is effectively a no-op, since the proof state is not massaged to the way
simp_memwants it to be. Subsequent PRs will focus on massaging the goal state to be assimp_memlikes, and then trying to symbolically simplify the memory expression we see.Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.
Co-authored-by @bollu[email protected]