feat: search for reads of *any* register when building an initial SymContext
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft because of the stack, but is otherwise ready for review. |
alexkeizer
force-pushed
the
refactor-state-monads-5
branch
from
8beb2b5 to
7e6b84f
Compare
alexkeizer
force-pushed
the
refactor-state-monads-6
branch
from
6a6a671 to
9b186cb
Compare
shigoel
previously approved these changes
Sep 30, 2024
|
@alexkeizer Please squash and merge this after the PR below in the stack makes it into |
alexkeizer
force-pushed
the
refactor-state-monads-6
branch
from
02e3456 to
b95fe25
Compare
|
@shigoel CI was unhappy because the benchmarks had a |
3 tasks
shigoel
approved these changes
Oct 3, 2024
shigoel
added a commit
that referenced
this pull request
Oct 3, 2024
### Description: Stacked on #200. This uses the `searchLCtx` machinery we built in #189 in `sym_aggregate`'s implementation. For now, this searches for exactly the same kind of expressions as before, but this makes it much easier to expand this set in the next PR. ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? yes ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Shilpi Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stacked on #189, we use the more powerful search capabilities to include hypotheses that describe reads from any
StateFieldinto the initial AxEffects.Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.