Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
geomean
computation that was incorrectly suggested by @bollu failed to take into account that theTotalRunTime
counter was adding the real runtimes, not multiplying them as one should for geomean.We change the
geomean
computation algorithm, to accumulate thelog
of the runtimes, and then divide byn
followed by exponentiation as a final step for better numerical accuracy.Testing:
What tests have been run? Did
make all
succeed for your changes? Wasconformance testing successful on an Aarch64 machine?
Conformance succeeds.
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.