Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Reflect folder to Sym, move SymContext to Sym/Context #187

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

alexkeizer
Copy link
Collaborator

Description:

Stacked on #182.

The new name makes more sense, since this is where I've been storing various components of the sym_n tactic implementation, even if they're not really doing reflection

Testing:

What tests have been run? Did make all succeed for your changes? Was
conformance testing successful on an Aarch64 machine? Yes

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@alexkeizer alexkeizer force-pushed the refactor-state-monads-3 branch from 33d9069 to 5105df6 Compare September 25, 2024 21:41
@alexkeizer alexkeizer force-pushed the refactor-state-monads-4 branch from c3a952a to d3cab07 Compare September 25, 2024 21:41
Base automatically changed from refactor-state-monads-3 to main September 26, 2024 17:55
…/Context`

The new name makes more sense, since this is where I've been storing various components of the `sym_n` tactic implementation, even if they're not really doing reflection
@alexkeizer alexkeizer force-pushed the refactor-state-monads-4 branch from d3cab07 to ad949b6 Compare September 26, 2024 21:00
@alexkeizer alexkeizer marked this pull request as ready for review September 26, 2024 21:00
@alexkeizer alexkeizer requested a review from shigoel as a code owner September 26, 2024 21:00
@alexkeizer
Copy link
Collaborator Author

@shigoel an easy one, this just moves around some files. Rebased and ready for review

@bollu
Copy link
Collaborator

bollu commented Sep 27, 2024

LGTM

@shigoel
Copy link
Collaborator

shigoel commented Sep 27, 2024

@alexkeizer Incoming conflicts.

@alexkeizer
Copy link
Collaborator Author

@shigoel I merged main

@shigoel shigoel merged commit 3f6b34e into main Sep 27, 2024
5 checks passed
@shigoel shigoel deleted the refactor-state-monads-4 branch September 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants