refactor: remove SymContext.h_err? field, move addGoalsForMissingHypotheses functionality into fromLocalContext
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
force-pushed
the
refactor-state-monads-2
branch
4 times, most recently
from
38d56c2 to
60e42dc
Compare
…ypotheses` functionality into `fromLocalContext` Note that we remove the ability to add a goal for `CheckSPAlignment`, this option was false by default, and never used
alexkeizer
force-pushed
the
refactor-state-monads-2
branch
from
60e42dc to
e023592
Compare
|
@shigoel This is now rebased and ready for review |
shigoel
approved these changes
Sep 26, 2024
shigoel
pushed a commit
that referenced
this pull request
Sep 26, 2024
### Description: Stacked on #181. This is the first step towards proper effect aggregation. Crucially, we don't use these updates in `sym_n` yet, as we need to integrate some form of CSE to make it actually usable ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? Yes ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Continues the cleanup started in #180 by getting rid of
h_err?andaddGoalsForMissingHypotheses.Note that we remove the ability to add a goal for
CheckSPAlignment, this option was false by default, and never usedTesting:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.