Skip to content

Commit

Permalink
chore: remove temporary reviewdog fix (#12284)
Browse files Browse the repository at this point in the history
 - [x] depends on: reviewdog/action-suggester#52


This reverts #12280 after the upstream fix
 reviewdog/reviewdog#1696
has propagated to reviewdog/action-suggester@v1. This should happen when 
https://github.com/reviewdog/action-suggester/releases
has a release that uses [v0.17.4](https://github.com/reviewdog/reviewdog/releases/tag/v0.17.4) or higher.

When this happens, rebase this pull request and re-trigger to see that it doesn't fail with the 300 dummy files. Then remove the dummy files and merge this pull request.



Co-authored-by: Moritz Firsching <[email protected]>
  • Loading branch information
mo271 and mo271 committed May 5, 2024
1 parent ff35083 commit 4218856
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/lint_and_suggest_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ jobs:
./scripts/lint-style.sh --fix
- name: suggester / lint-style
# temporary fix for https://github.com/reviewdog/reviewdog/issues/1696#issue-2206596164
if: ${{ github.event.pull_request.changed_files < 301 }}
uses: reviewdog/action-suggester@v1
with:
tool_name: lint-style
Expand All @@ -44,8 +42,6 @@ jobs:
./scripts/lint-bib.sh
- name: suggester / lint-bib
# temporary fix for https://github.com/reviewdog/reviewdog/issues/1696#issue-2206596164
if: ${{ github.event.pull_request.changed_files < 301 }}
uses: reviewdog/action-suggester@v1
with:
tool_name: lint-bib
Expand Down Expand Up @@ -78,8 +74,6 @@ jobs:
git ls-files 'Archive/*.lean' | LC_ALL=C sort | sed 's/\.lean//;s,/,.,g;s/^/import /' > Archive.lean
- name: suggester / import list
# temporary fix for https://github.com/reviewdog/reviewdog/issues/1696#issue-2206596164
if: ${{ github.event.pull_request.changed_files < 301 }}
uses: reviewdog/action-suggester@v1
with:
tool_name: imports

0 comments on commit 4218856

Please sign in to comment.